This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: File-name completer marks all files as executable on MS-Windows
- From: Chet Ramey <chet dot ramey at case dot edu>
- To: Eli Zaretskii <eliz at gnu dot org>
- Cc: chet dot ramey at case dot edu, gdb-patches at sourceware dot org
- Date: Mon, 29 Dec 2014 11:46:48 -0500
- Subject: Re: File-name completer marks all files as executable on MS-Windows
- Authentication-results: sourceware.org; auth=none
- References: <83egrklxde dot fsf at gnu dot org> <54A17585 dot 5010900 at case dot edu> <83bnmmjuio dot fsf at gnu dot org>
- Reply-to: chet dot ramey at case dot edu
On 12/29/14 11:22 AM, Eli Zaretskii wrote:
>> Date: Mon, 29 Dec 2014 10:38:45 -0500
>> From: Chet Ramey <chet.ramey@case.edu>
>> CC: chet.ramey@case.edu, gdb-patches@sourceware.org
>>
>> On 12/27/14 2:13 PM, Eli Zaretskii wrote:
>>> I discovered that completing on file names in GDB on MS-Windows marks
>>> every file as executable. This is because Readline uses 'access' and
>>> X_OK to determine that, which doesn't work on Windows.
>>
>> Ugh, really? Thanks for the patch.
>
> Thanks for reviewing it.
>
> Joel, Pedro, others: can I now commit this to the GDB repository?
I am not certain of the exact vintage of the copy of readline in the GDB
repository, but you should probably audit it and see whether or not this
patch should use `fn' instead of `filename'.
--
``The lyf so short, the craft so long to lerne.'' - Chaucer
``Ars longa, vita brevis'' - Hippocrates
Chet Ramey, ITS, CWRU chet@case.edu http://cnswww.cns.cwru.edu/~chet/