This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Don't munge yacc's #line directives


On 01/08/2015 12:48 PM, Patrick Palka wrote:

> Here is the upstream automake patch that is probably responsible for
> making the sed expression in question obsolete:
> http://git.savannah.gnu.org/cgit/automake.git/commit/lib/ylwrap?id=b6359a5f310160c8a4a2e8e8c0105408412ce400

I find that a bit confusing, since the comment says:

 # We don't want the resulting debug information to point at
 # an absolute srcdir.

(the upstream master version still has the comment, though
reformatted).

In any case, I think we've done due diligence already.

Could you update the commit log with the new findings and
references, and please also include an before/after example
of a #line line?  With that, the patch is OK.

E.g., here's what I see, before/after your patch:

 -#line 36 "/home/pedro/gdb/mygit/src/gdb//home/pedro/gdb/mygit/src/gdb/ada-exp.y"
 +#line 36 "/home/pedro/gdb/mygit/src/gdb/ada-exp.y"

Thanks,
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]