This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [REVERTED PATCH] symbol lookup cache
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Doug Evans <xdje42 at gmail dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Mon, 12 Jan 2015 09:06:18 +0400
- Subject: Re: [REVERTED PATCH] symbol lookup cache
- Authentication-results: sourceware.org; auth=none
- References: <CAP9bCMTbQis9_8uRB5R7CKh_hQY=ROJmTZDV4SsUPupfFFChnA at mail dot gmail dot com>
> A 20x speedup on a simple "ptype std_string_var" is really nice,
> [and it'll only get better the larger the app, e.g., the larger the number
> of shared libraries], and I expect there'll be such examples,
> but whether the patch is ready for release ... I think it is, but I've
> already found one issue ...
We have the option of delaying the branch, and in fact, I will for now
delay until at least tomorrow so we can discuss what we want to do.
FWIW, here is what I think: I think symbol lookup is generally critical,
and I would be extra cautious before pushing big chunks of code that late
in the process, particularly if it's "just" to improve pre-existing
performance (pardon the "just" - it is not qualifying nor quantifying
the benefits of your patch).
That's why I would personally leave your patch out of the 7.9 branch.
But that's only based on a general impression of the patch, so, as
I said, everyone is welcome to weigh in on the decision.
--
Joel