This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] PR17525 - breakpoint commands not executed when program run, from -x script


Hi Pedro,

> gdb/
> 2015-01-12  Pedro Alves  <palves@redhat.com>
> 
> 	PR gdb/17525
> 	* breakpoint.c: Include "interps.h".
> 	(bpstat_do_actions_1): Also check whether the interpreter is
> 	async.
> 
> gdb/testsuite/
> 2015-01-12  Pedro Alves  <palves@redhat.com>
> 	    Joel Brobecker  <brobecker@adacore.com>
> 
> 	PR gdb/17525
> 	* gdb.base/bp-cmds-execution-x-script.c: New file.
> 	* gdb.base/bp-cmds-execution-x-script.exp: New file.
> 	* gdb.base/bp-cmds-execution-x-script.gdb: New file.

Many many thanks for the fix.

I completely missed the fact that we were running in non-async
mode, and now I am slapping the front of my head yelling a "duh!".
I learnt something from your help, so thank you. And the bonus
is that the fix looks fairly simple, which is good, because...

... this is an issue which was identified as a regression for
7.8 and 7.9. I suggest we backport them to both branches, if
you agree, and once the patch is pushed to master, I volunteer
doing so if that saves you a bit of time.

Regarding GDBFLAGS, I'm wondering whether this might be one of
those globals that we should be restoring at the start of each
testcase (via gdb_init)...

-- 
Joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]