This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 3/3 v2] Implement completion limiting
- From: Gary Benson <gbenson at redhat dot com>
- To: Doug Evans <dje at google dot com>
- Cc: Eli Zaretskii <eliz at gnu dot org>, gdb-patches <gdb-patches at sourceware dot org>
- Date: Thu, 15 Jan 2015 15:39:30 +0000
- Subject: Re: [PATCH 3/3 v2] Implement completion limiting
- Authentication-results: sourceware.org; auth=none
- References: <1417094168-25868-1-git-send-email-gbenson at redhat dot com> <1417094168-25868-4-git-send-email-gbenson at redhat dot com> <m3y4ql4psf dot fsf at sspiff dot org> <20141210122233 dot GA7299 at blade dot nx> <m3mw6v4gm8 dot fsf at sspiff dot org> <21671 dot 20308 dot 262958 dot 475080 at ruffy2 dot mtv dot corp dot google dot com> <20150107084255 dot GA17867 at blade dot nx> <21680 dot 36641 dot 315766 dot 209208 at ruffy2 dot mtv dot corp dot google dot com> <83a91r6lbd dot fsf at gnu dot org> <CADPb22TOJ2uqQKyzEpQyCrm92-ARexduUk0b2rDqJwQvdU1uLw at mail dot gmail dot com>
Doug Evans wrote:
> On Sat, Jan 10, 2015 at 1:23 AM, Eli Zaretskii <eliz@gnu.org> wrote:
> > > From: Doug Evans <dje@google.com>
> > > Date: Fri, 9 Jan 2015 18:32:01 -0800
> > > Cc: gdb-patches@sourceware.org
> > >
> > > +If the number of possible completions is large, @value{GDBN} will
> > > +print as much of the list as it has collected, as well as a message
> > > +indicating that the list may be truncated.
> > > +
> > > +@smallexample
> > > +(@value{GDBP}) b m@key{TAB}@key{TAB}
> > > +m *** List may be truncated, max-completions reached. ***
> > > +main
> > > +<... the rest of the possible completions ...>
> > > +(@value{GDBP}) b m
> >
> > Doesn't the "list may be truncated" message scrolls off the
> > screen, if the list is long enough? If so, wouldn't it be better
> > to display that message at the end instead, saying something like
> >
> > (More completions follow; max-completions exceeded.)
>
> If the user sets a bad height, or if pagination is turned off,
> possibly.
>
> I can put it at the end.
I'd prefer it at the end.
Cheers,
Gary
--
http://gbenson.net/