This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Speed up "gdb -tui" output
- From: Doug Evans <xdje42 at gmail dot com>
- To: Eli Zaretskii <eliz at gnu dot org>, Pedro Alves <palves at redhat dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Mon, 19 Jan 2015 10:32:48 -0800
- Subject: Re: [PATCH] Speed up "gdb -tui" output
- Authentication-results: sourceware.org; auth=none
- References: <83zj9v7urq dot fsf at gnu dot org> <CADPb22Q7oD3K-dYkngEPDBbV++mLCKifTEmvJczQ=0h2FX0yXA at mail dot gmail dot com> <83sifn7mpt dot fsf at gnu dot org> <CADPb22QeiSrzD81kMJeqpnDBrx1DybpbGmHc1r0koGDtqAu8tw at mail dot gmail dot com> <83h9w278a9 dot fsf at gnu dot org> <CADPb22R_=xwonUGJMxJRtAbbK8OcSmU5ojarB=T9wjg9YEtE6Q at mail dot gmail dot com> <83bnma75yt dot fsf at gnu dot org> <CADPb22SvEa8-+y009ET7PQDuYixGEK6LbrJr_pyQ98SfVy_iJg at mail dot gmail dot com> <837fwy74ny dot fsf at gnu dot org> <CADPb22QZ8qgfYfsT=wxQg8yKRE3EzPTc8QHcHpk8oXpA6DsA2A at mail dot gmail dot com> <21677 dot 44074 dot 982761 dot 250152 at ruffy2 dot mtv dot corp dot google dot com> <83iog2y7s9 dot fsf at gnu dot org>
On Mon, Jan 19, 2015 at 9:55 AM, Eli Zaretskii <eliz@gnu.org> wrote:
>> From: Doug Evans <dje@google.com>
>> Date: Wed, 7 Jan 2015 13:59:06 -0800
>>
>> Doug Evans writes:
>> > Seems like the main source of the problem would be gdb_stdout,
>> > so let's try to fix that first and go from there.
>>
>> Here's a prototype.
>
> Sorry for a long delay. I tried this (and Pedro's) patch today. They
> both do the job, so one of them should IMO be committed, master and
> branch.
>
>> @@ -239,6 +243,12 @@ tui_file_flush (struct ui_file *file)
>> case astring:
>> break;
>> case afile:
>> + /* There is also gdb_stdlog, gdb_stdtarg, gdb_stdtargerr, but
>> + tui_setup_io maps those to gdb_stderr. OTOH, do we need to make
>> + this conditional? */
>> + if (file == gdb_stdout
>> + || file == gdb_stderr)
>> + tui_refresh_cmd_win ();
>
> I indeed think that the condition should be removed. I see no need
> for it: there's no reason to make any stream displayed on TUI more
> than line-buffered.
I don't have a preference on which, with one condition.
If we're going to remove the fflush's let's do it as a separate patch.