This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] [python] Optimize python_string_to_host_string() for Python 2.
- From: Phil Muldoon <pmuldoon at redhat dot com>
- To: "Yichun Zhang (agentzh)" <agentzh at gmail dot com>, gdb-patches <gdb-patches at sourceware dot org>
- Date: Tue, 20 Jan 2015 11:13:16 +0000
- Subject: Re: [PATCH] [python] Optimize python_string_to_host_string() for Python 2.
- Authentication-results: sourceware.org; auth=none
- References: <1421217481-18204-1-git-send-email-agentzh at gmail dot com> <CAB4Tn6MB6tCQ6N6-XEZNBOwEvF-s7oMN=H7mzuhuq1GQfZWuXg at mail dot gmail dot com>
On 19/01/15 22:08, Yichun Zhang (agentzh) wrote:
> Hello!
>
> On Tue, Jan 13, 2015 at 10:38 PM, Yichun Zhang (agentzh) wrote:
>> With the following patch, my most complicated Python tools
>> finally have comparable performance between Python 2 and
>> Python 3. In the case of Python 2, some real-world Python scripts'
>> overall speedup can be as big as 34% (for my "lgcpath" command [3])
>> or even 57% (for my "lgcstat" command [4]). And from the new Flame
>> Graph [5], we can see that the corresponding function frames are
>> indeed gone.
>>
>> Comments are welcome!
>>
>
> Does the silence in the last 6 days mean that this patch is completely wrong?
Not at all. I think the post Christmas catch-up has affected patch
review and there is some lag. I am sure the maintainers will review
your patch soon.
> Actually I have a few more patches to submit to optimize this
> gdb/python part even further. The silence here makes me hesitate ;)
Please submit them. There is no hesitation on commenting on patches
constructively. For my part, I find no issue with people indicating
what might be wrong (or right) with my patches!
> Please let me know if I'm doing something wrong here. Very much appreciated!
You are doing nothing wrong. Keep pinging your patches. The usual
wait time for pinging a patch is seven days.
Cheers
Phil