This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Unify CLI/TUI tab-completion match list displayers
- From: Doug Evans <xdje42 at gmail dot com>
- To: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Wed, 21 Jan 2015 10:20:36 -0800
- Subject: Re: [PATCH] Unify CLI/TUI tab-completion match list displayers
- Authentication-results: sourceware.org; auth=none
- References: <m3zj9c9iln dot fsf at sspiff dot org>
On Wed, Jan 21, 2015 at 8:57 AM, Doug Evans <xdje42@gmail.com> wrote:
> Hi.
>
> This patch unifies CLI/TUI tab-completion match list displayers.
> In doing so it fixes a few bugs:
>
> - TUI now has pagination of match list output (yay)
> - directories in TUI output get / appended (minor yay)
> - fixes Ctrl-g handling in the CLI version (yay)
> [There are some other nits which the CLI version has, e.g., if
> gdb displays output after the first tab (dwarf complaints) then
> the prompt + text thus far isn't re-printed, presumably because
> readline isn't aware of the output. I'm leaving that for another pass,
> but I like fixing Ctrl-g now.]
>
> ...
>
> + This function handles the LIST_MAYBE_TRUNCATED marker that we add to the
> + completion list.
> +
> + Note: While LIST_MAYBE_TRUNCATED contributes to MAX, it's not long enough
> + that we worry about it. */
Bleah. Ignore this part of the patch.
That's part of a followup patch.
Fixing TUI match list pagination (that heads in a direction of
completely cleaning up TUI match list display) is enough for me to
push this in now.