This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patchv2] Sort threads for thread apply all (bt)
- From: Doug Evans <dje at google dot com>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- Cc: Pedro Alves <palves at redhat dot com>, gdb-patches <gdb-patches at sourceware dot org>
- Date: Thu, 22 Jan 2015 10:07:37 -0800
- Subject: Re: [patchv2] Sort threads for thread apply all (bt)
- Authentication-results: sourceware.org; auth=none
- References: <20150115183316 dot GA16405 at host2 dot jankratochvil dot net> <CADPb22R_dY8nfU4bgpPS+4K5gG9cdMzCqW--H85hMwBDdh+MRg at mail dot gmail dot com> <20150116233802 dot GA8732 at host2 dot jankratochvil dot net> <21696 dot 17350 dot 451535 dot 337528 at ruffy2 dot mtv dot corp dot google dot com> <54C0DC83 dot 20401 at redhat dot com> <20150122164301 dot GA11240 at host2 dot jankratochvil dot net> <54C12E55 dot 1040907 at redhat dot com> <20150122171757 dot GA12383 at host2 dot jankratochvil dot net>
On Thu, Jan 22, 2015 at 9:17 AM, Jan Kratochvil
<jan.kratochvil@redhat.com> wrote:
> On Thu, 22 Jan 2015 18:07:33 +0100, Pedro Alves wrote:
>> https://sourceware.org/bugzilla/show_bug.cgi?id=17539
>
> While we're getting to the classical bikeshed before coding in the '-desc'
> option I would like to reassure we should not go the global setting way
> instead which I would find more appropriate myself in such situation, contrary
> to what Doug said:
>
> On Thu, 15 Jan 2015 20:29:07 +0100, Doug Evans wrote:
> # Do we want an option to choose the sort direction?
> # [I wouldn't make it a global parameter, just an option to
> # thread apply.]
I'd rather not add to the global state until there's a justified reason for it.
We're not there yet IMO.
And we can add -desc later.
[Though -asc vs -desc is a bit awkward.
-a and -d?
-ascending and -descending ?]
So I'm happy with the patch as is.
[Which isn't to say I wouldn't be happy with
something different though.]