This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: "make TAGS" broken in 7.8.90
- From: Eli Zaretskii <eliz at gnu dot org>
- To: gdb-patches at sourceware dot org
- Cc: sergiodj at redhat dot com
- Date: Thu, 22 Jan 2015 20:09:51 +0200
- Subject: Re: "make TAGS" broken in 7.8.90
- Authentication-results: sourceware.org; auth=none
- References: <83twzlwe3p dot fsf at gnu dot org>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> Date: Tue, 20 Jan 2015 19:34:18 +0200
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: Sergio Durigan Junior <sergiodj@redhat.com>
>
> "make TAGS" is broken. Again. (Sergio, would it make sense to add
> "make TAGS" to the list of commands run by the buildbot after a build?
> This breaks too often, IMO.)
>
> Doing TAGS in gdb
> make[2]: Entering directory `/d/usr/eli/utils/gdb-7.8.90/gdb'
> make[2]: *** No rule to make target `ada-varobj.h', needed by `TAGS'.
> make[2]: Target `TAGS' not remade because of errors.
> ./x86-dregs.c: No such file or directory
> ./irix5-nat.c: No such file or directory
>
> ada-varobj.h and irix5-nat.c should simply be removed from the
> respective lists.
I've just pushed the below as obvious.
> But I'm not sure how to fix the x86-dregs.c issue.
> The problem here is that x86-dregs.o is in gdb/, but the source is in
> gdb/nat/, so the simplistic editing:
>
> done) | sed 's/\.o$$/\.c/'` \
>
> doesn't work. Thoughts?
>
> One other annoyance with "make TAGS" is that libdecnumber doesn't
> support that target, so you must invoke the command from gdb/, or use
> "make -k", otherwise it bails out. Any reason not to support TAGS in
> libdecnumber?
Still didn't fix these. Any ideas for an elegant solution?
commit 82a864f96aff83edb0c8bb21ead5c28cd10363fe
Author: Eli Zaretskii <eliz@gnu.org>
Date: Thu Jan 22 20:05:59 2015 +0200
Partial fix for "make TAGS".
gdb/
2015-01-22 Eli Zaretskii <eliz@gnu.org>
* Makefile.in (HFILES_NO_SRCDIR): Remove ada-varobj.h.
(ALLDEPFILES): Remove irix5-nat.c. These two are part of the
reason that "make TAGS" is broken.
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index fee6903..06be4ed 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,9 @@
+2015-01-22 Eli Zaretskii <eliz@gnu.org>
+
+ * Makefile.in (HFILES_NO_SRCDIR): Remove ada-varobj.h.
+ (ALLDEPFILES): Remove irix5-nat.c. These two are part of the
+ reason that "make TAGS" is broken.
+
2015-01-22 Chen Gang <gang.chen.5i5j@gmail.com>
* hppa-tdep.c (inst_saves_gr): Fix logical working flow issues
diff --git a/gdb/Makefile.in b/gdb/Makefile.in
index 6b270eb..8addef4 100644
--- a/gdb/Makefile.in
+++ b/gdb/Makefile.in
@@ -890,7 +890,7 @@ proc-utils.h aarch64-tdep.h arm-tdep.h ax-gdb.h ppcfbsd-tdep.h \
ppcnbsd-tdep.h cli-out.h gdb_expat.h breakpoint.h infcall.h obsd-tdep.h \
exec.h m32r-tdep.h osabi.h gdbcore.h solib-som.h amd64bsd-nat.h \
i386bsd-nat.h xml-support.h xml-tdesc.h alphabsd-tdep.h gdb_obstack.h \
-ia64-tdep.h ada-lang.h ada-varobj.h varobj.h varobj-iter.h frv-tdep.h \
+ia64-tdep.h ada-lang.h varobj.h varobj-iter.h frv-tdep.h \
nto-tdep.h serial.h \
c-lang.h d-lang.h go-lang.h frame.h event-loop.h block.h cli/cli-setshow.h \
cli/cli-decode.h cli/cli-cmds.h cli/cli-utils.h \
@@ -1666,7 +1666,6 @@ ALLDEPFILES = \
ia64-hpux-nat.c ia64-hpux-tdep.c \
ia64-linux-nat.c ia64-linux-tdep.c ia64-tdep.c ia64-vms-tdep.c \
inf-ptrace.c inf-ttrace.c \
- irix5-nat.c \
ia64-libunwind-tdep.c \
linux-fork.c \
linux-tdep.c \