This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patchv3] Sort threads for thread apply all (bt)


On Thu, Jan 22, 2015 at 10:46 AM, Jan Kratochvil
<jan.kratochvil@redhat.com> wrote:
> ...
>> This triggers my "passing parameters as global variables" alarm,
>> and while one could instead have two different functions,
>
> I believe qsort_r() is more appropriate, using two different functions I would
> feel rather as a workaround of missing qsort_r(). But I guess (I cannot easily
> test due to missing slaves and no patch testing feature in Sergio's Buildbot
> yet) some of the supported platforms do not provide qsort_r() so it would need
> a new gdb/gnulib/ module. But at least one of my gdb/gnulib/ patches is still
> under review so it would create dependency between unrelated patchsets.

I think you're splitting hairs here.

> +  if (cmd != NULL && (check_for_argument (&cmd, "-ascending", strlen ("-asc"))))

strlen ("-ascending")

Also, remove the extra parens around check_for_argument?


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]