This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 4/6] Constify some parameters in the varobj code
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Simon Marchi <simon dot marchi at ericsson dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 30 Jan 2015 07:33:26 +0400
- Subject: Re: [PATCH 4/6] Constify some parameters in the varobj code
- Authentication-results: sourceware.org; auth=none
- References: <1422559716-5480-1-git-send-email-simon dot marchi at ericsson dot com> <1422559716-5480-4-git-send-email-simon dot marchi at ericsson dot com>
> I did that to make sure there was no other cases like the one fixed in
> the previous patch. I don't think it can hurt.
Agreed.
> gdb/ChangeLog:
>
> * ada-varobj.c (ada_number_of_children): Constify struct varobj *
> parameter.
> (ada_name_of_variable): Same.
> (ada_path_expr_of_child): Same.
> (ada_value_of_variable): Same.
> (ada_value_is_changeable_p): Same.
> (ada_value_has_mutated): Same.
> * c-varobj.c (varobj_is_anonymous_child): Same.
> (c_is_path_expr_parent): Same.
> (c_number_of_children): Same.
> (c_name_of_variable): Same.
> (c_path_expr_of_child): Same.
> (get_type): Same.
> (c_value_of_variable): Same.
> (cplus_number_of_children): Same.
> (cplus_name_of_variable): Same.
> (cplus_path_expr_of_child): Same.
> (cplus_value_of_variable): Same.
> * jv-varobj.c (java_number_of_children): Same.
> (java_name_of_variable): Same.
> (java_path_expr_of_child): Same.
> (java_value_of_variable): Same.
> * varobj.c (number_of_children): Same.
> (name_of_variable): Same.
> (is_root_p): Same.
> (varobj_ensure_python_env): Same.
> (varobj_get_objname): Same.
> (varobj_get_expression): Same.
> (varobj_get_display_format): Same.
> (varobj_get_display_hint): Same.
> (varobj_has_more): Same.
> (varobj_get_thread_id): Same.
> (varobj_get_frozen): Same.
> (dynamic_varobj_has_child_method): Same.
> (varobj_get_gdb_type): Same.
> (is_path_expr_parent): Same.
> (varobj_default_is_path_expr_parent): Same.
> (varobj_get_language): Same.
> (varobj_get_attributes): Same.
> (varobj_is_dynamic_p): Same.
> (varobj_get_child_range): Same.
> (varobj_value_has_mutated): Same.
> (varobj_get_value_type): Same.
> (number_of_children): Same.
> (name_of_variable): Same.
> (check_scope): Same.
> (varobj_editable_p): Same.
> (varobj_value_is_changeable_p): Same.
> (varobj_floating_p): Same.
> (varobj_default_value_is_changeable_p): Same.
> * varobj.h (struct lang_varobj_ops): Consitfy some struct varobj *
> parameters.
> (varobj_get_objname): Constify struct varobj * parameter.
> (varobj_get_expression): Same.
> (varobj_get_thread_id): Same.
> (varobj_get_frozen): Same.
> (varobj_get_child_range): Same.
> (varobj_get_display_hint): Same.
> (varobj_get_gdb_type): Same.
> (varobj_get_language): Same.
> (varobj_get_attributes): Same.
> (varobj_editable_p): Same.
> (varobj_floating_p): Same.
> (varobj_has_more): Same.
> (varobj_is_dynamic_p): Same.
> (varobj_ensure_python_env): Same.
> (varobj_default_value_is_changeable_p): Same.
> (varobj_value_is_changeable_p): Same.
> (varobj_get_value_type): Same.
> (varobj_is_anonymous_child): Same.
> (varobj_value_get_print_value): Same.
> (varobj_default_is_path_expr_parent): Same.
Sorry you had to write such as long ChangeLog entry. CL can be useful
at times, but really a timewaster at others :-(.
The patch looks pretty good to me, with a few corrections to avoid
some lines that became too long. Pre-approved with those adjustments.
--
Joel