This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2] sim: Be sure of calling freeargv() after successfully call buildargv().
- From: Chen Gang S <gang dot chen at sunrus dot com dot cn>
- To: gdb-patches at sourceware dot org, Michael Eager <eager at eagerm dot com>
- Date: Tue, 03 Feb 2015 04:16:53 +0800
- Subject: Re: [PATCH v2] sim: Be sure of calling freeargv() after successfully call buildargv().
- Authentication-results: sourceware.org; auth=none
- References: <54CFDAF2 dot 5050904 at sunrus dot com dot cn>
If there will be no any additional reply within this week, I shall apply
the related 3 patches to main branch.
Thanks.
On 2/3/15 04:15, Chen Gang S wrote:
> Or there will be memory leak.
>
> 2015-02-02 Chen Gang <gang.chen.5i5j@gmail.com>
>
> * microblaze/interp.c (sim_do_command): Call freeargv() before
> return.
> ---
> sim/ChangeLog | 5 +++++
> sim/microblaze/interp.c | 3 +++
> 2 files changed, 8 insertions(+)
>
> diff --git a/sim/ChangeLog b/sim/ChangeLog
> index 1fe93df..582bd4a 100644
> --- a/sim/ChangeLog
> +++ b/sim/ChangeLog
> @@ -1,5 +1,10 @@
> 2015-02-02 Chen Gang <gang.chen.5i5j@gmail.com>
>
> + * microblaze/interp.c (sim_do_command): Call freeargv() before
> + return.
> +
> +2015-02-02 Chen Gang <gang.chen.5i5j@gmail.com>
> +
> * mcore/interp.c (sim_do_command): Call freeargv() before return.
>
> 2015-02-02 Chen Gang <gang.chen.5i5j@gmail.com>
> diff --git a/sim/microblaze/interp.c b/sim/microblaze/interp.c
> index 1c8a22d..4fc4595 100644
> --- a/sim/microblaze/interp.c
> +++ b/sim/microblaze/interp.c
> @@ -1019,6 +1019,7 @@ sim_do_command (SIM_DESC sd, const char *cmd)
> if ((simargv[1] == NULL) || (simargv[2] == NULL))
> {
> fprintf (stderr, "Error: missing argument to watch cmd.\n");
> + freeargv (simargv);
> return;
> }
>
> @@ -1062,6 +1063,8 @@ sim_do_command (SIM_DESC sd, const char *cmd)
> fprintf (stderr,"Error: \"%s\" is not a valid M.CORE simulator command.\n",
> cmd);
> }
> +
> + freeargv (simargv);
> }
> else
> {
>
--
Chen Gang
Open, share, and attitude like air, water, and life which God blessed