This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PING] [PATCH 0/3] Fix for PR 17808 and some related changes


On 02/02/2015 04:50 AM, Joel Brobecker wrote:
> On Thu, Jan 29, 2015 at 04:58:07PM +0100, Andreas Arnez wrote:
>> Ping:
>>
>>   https://sourceware.org/ml/gdb-patches/2015-01/msg00424.html
>>
>> Pedro commented already, as shown below.  Mark has not replied so far.
>>
>> Note that the PR is on the TODO list for 7.9.  In my opinion at least
>> patch 1 should go in 7.9; it's fairly harmless and should fix the PR.
>> Patch 2 fixes a similar problem, but there might be a test gap, because
>> I currently don't have access to appropriate test hardware (with AVX and
>> AVX-512).  And with patch 3 there's a slight chance of introducing bogus
>> warnings when reading core files.  Thus I'd suggest to push all three
>> patches upstream, but only patch 1 into 7.9.  OK?
> 
> Let's give it another week for additional comments (or request for
> more time to review), and then push it to master.
> 
> For 7.9, let's confirm your assessment with Pedro. It sounds pretty
> good to me.
> 

Sounds good to me, but I have a counter proposal.

How about we push it all to master now?  That'd give it exposure on
both auto testers and on others' machines immediately.  We can always
address any additional comments as follow ups, of course.  The main
difference is that the series would be exposed to testing one
extra week.  Then if we see no fall out, we'd have a little more
confidence pushing to 7.9.

Thanks,
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]