This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Implement ${board}_{exec,spawn} for native-extended-gdbserver
- From: Pedro Alves <palves at redhat dot com>
- To: Sergio Durigan Junior <sergiodj at redhat dot com>, GDB Patches <gdb-patches at sourceware dot org>
- Cc: Mark Wielaard <mark at klomp dot org>
- Date: Wed, 04 Feb 2015 14:05:53 +0100
- Subject: Re: [PATCH] Implement ${board}_{exec,spawn} for native-extended-gdbserver
- Authentication-results: sourceware.org; auth=none
- References: <1423005658-31405-1-git-send-email-sergiodj at redhat dot com>
On 02/04/2015 12:20 AM, Sergio Durigan Junior wrote:
> diff --git a/gdb/testsuite/boards/native-extended-gdbserver.exp b/gdb/testsuite/boards/native-extended-gdbserver.exp
> index 57503db..0059c4e 100644
> --- a/gdb/testsuite/boards/native-extended-gdbserver.exp
> +++ b/gdb/testsuite/boards/native-extended-gdbserver.exp
> @@ -23,12 +23,6 @@
> load_generic_config "extended-gdbserver"
> load_board_description "gdbserver-base"
>
> -# By default, dejagnu makes the board remote unless the board name
> -# matches localhost. Force it to be NOT remote.
> -global board
> -global board_info
> -set board_info($board,isremote) 0
I don't think we can/should remove this. That'll make
"is_remote" checks all over the testsuite return true,
and thus skip tests that weren't skipped before. E.g.,
solib-display.exp.
I think we need to instead do here what ${board}_spawn
is already doing. That is, remove any target variant
specifications from $board, like:
--- a/gdb/testsuite/boards/native-extended-gdbserver.exp
+++ b/gdb/testsuite/boards/native-extended-gdbserver.exp
@@ -27,7 +27,9 @@ load_board_description "gdbserver-base"
# matches localhost. Force it to be NOT remote.
global board
global board_info
-set board_info($board,isremote) 0
+# Remove any target variant specifications from the name.
+set baseboard [lindex [split $board "/"] 0]
+set board_info($baseboard,isremote) 0
I'm testing that.
Thanks,
Pedro Alves