This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 09/36] floatformat.h: Wrap in extern "C".
- From: Doug Evans <xdje42 at gmail dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: Andrew Pinski <pinskia at gmail dot com>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Sat, 14 Feb 2015 14:46:17 -0800
- Subject: Re: [PATCH 09/36] floatformat.h: Wrap in extern "C".
- Authentication-results: sourceware.org; auth=none
- References: <1423524046-20605-1-git-send-email-palves at redhat dot com> <1423524046-20605-10-git-send-email-palves at redhat dot com> <CA+=Sn1npOYOeTU6ShGk50Vcy=ZpuYMjUfDac0gXWU20grzyoyw at mail dot gmail dot com> <54D94780 dot 9050606 at redhat dot com> <CAP9bCMRuP9bkUDj-PzokDQs02PfwOirq5b2Uda=Rw-KKfSs3tg at mail dot gmail dot com> <54DF95AC dot 2090707 at redhat dot com>
On Sat, Feb 14, 2015 at 10:36 AM, Pedro Alves <palves@redhat.com> wrote:
> On 02/14/2015 05:29 PM, Doug Evans wrote:
>> On Mon, Feb 9, 2015 at 3:49 PM, Pedro Alves <palves@redhat.com> wrote:
>>> On 02/09/2015 11:35 PM, Andrew Pinski wrote:
>>>> Why is not needed for GCC building with C++ compiler?
>>>
>>> Because it doesn't include it.
>>>
>>> The header of the file claims it is part of GDB, though MAINTAINERS
>>> nowadays says that everything under include/ is owned by GCC.
>>
>> Wait, what?
>>
>> The actual wording is:
>> "The rule is that if the file exists in the gcc tree then gcc owns it."
>
> I was paraphrasing, and simplified it. That distinction seems
> irrelevant to me here because the file does exist in the gcc tree.
> It's necessary to build libiberty (for libiberty/floatformat.o).
No worries, I just wanted to make sure it didn't say something
it shouldn't.
> It's a fact that the header claims it is part of GDB:
>
> ~~~~~~
> /* IEEE floating point support declarations, for GDB, the GNU Debugger.
> Copyright (C) 1991-2015 Free Software Foundation, Inc.
>
> This file is part of GDB.
> (...)
> ~~~~~~
>
> I guess it should say that it is part of libiberty instead.
At the least the current wording is confusing.
>> It originated from this thread,
>> https://sourceware.org/ml/gdb/2013-11/msg00025.html
>> That's not the first message in the thread, but that's where
>> I remember wanting to see something written down.
>>
>> Perhaps kinda unfortunate for things like include/gdb/gdb-index.h.
>> But at least it's a rule that can be expressed in one sentence,
>> and I don't think it's been a problem.
>
> I'm confused -- I didn't say it was a problem, nor expressed any
> concern with the rule. I just was pointing out facts.
I didn't say you said it was a problem.
It was just an offhand comment about the rule itself,
not anything you said.
> ISTM that the procedure here is to push this change first through
> the gcc repo first, and then merge it to binutils-gdb git. Is that
> wrong?
That's the procedure as I understand it.