This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH V4 0/9] Add support for DTrace USDT probes to gdb
- From: jose dot marchesi at oracle dot com (Jose E. Marchesi)
- To: Sergio Durigan Junior <sergiodj at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 17 Feb 2015 13:02:14 +0100
- Subject: Re: [PATCH V4 0/9] Add support for DTrace USDT probes to gdb
- Authentication-results: sourceware.org; auth=none
- References: <1422874968-382-1-git-send-email-jose dot marchesi at oracle dot com> <877fvh710o dot fsf at redhat dot com>
> [Changes from V3:
> - Added some missing spaces after periods in the documentation patch.
> Spotted by Eli.
> - Sort ChangeLog entries so they reflect the changes in the same order
> than the diffs.
> - Use transformed tool names in the pdtrace script, which is now
> processed through configure. Introduce a new GDB_AC_TRANSFORM macro
> to avoid repeating a code idiom and use it to define both
> GDB_TRANSFORM_NAME and GCORE_TRANSFORM_NAME in the main
> configure.ac.
> - Copyright year updated to 2015 in new files introduces by the patch
> series.]
Thanks for the series, Jose!
The patches look pretty good. I approved almost all of them. The only
exception is the testcase patch, but not because of the testcase per se:
rather, it is because the new transform.m4 file that you added. I think
we're 99% done on this. Let's just wait to see what Pedro thinks about
the transform thing (since he was the one who requested it before).
Thanks. I will remove the GDB_AC_TRANSFORM M4 macro from [PATCH V4 7/9]
and make it use verbose idioms in gdb/testsuite/configure.ac:
STRIP_TRANSFORM_NAME=`echo strip | sed -e "$transform"`
if test "x$STRIP_TRANSFORM_NAME" = x; then
STRIP_TRANSFORM_NAME=strip
fi
[... same for readelf, as and nm]
And then I will push the patches to trunk.
Later I will send a separated patch with the addition of
GDB_AC_TRANSFORM for Pedro's consideration.
Salud!