This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] [guile] Run finalizers from GDB thread
- From: Doug Evans <xdje42 at gmail dot com>
- To: Andy Wingo <wingo at igalia dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Sun, 22 Feb 2015 14:05:29 -0800
- Subject: Re: [PATCH] [guile] Run finalizers from GDB thread
- Authentication-results: sourceware.org; auth=none
- References: <87sipcqdmo dot fsf at igalia dot com> <m38uqrsuqh dot fsf at sspiff dot org> <878ug5965t dot fsf at igalia dot com>
Andy Wingo <wingo@igalia.com> writes:
> Hi :)
>
> On Sat 26 Apr 2014 22:26, Doug Evans <xdje42@gmail.com> writes:
>
>> Andy Wingo <wingo@igalia.com> writes:
>>
>>> gdb/ChangeLog:
>>> * guile/guile.c (_initialize_guile): Disable automatic
>>> finalization, if Guile offers us that possibility.
>>>
>>> * guile/guile.c (call_initialize_gdb_module):
>>> * guile/scm-safe-call.c (gdbscm_with_catch): Arrange to run
>>> finalizers in appropriate places.
>>>
>>> * configure.ac: Add a check for
>>> scm_set_automatic_finalization_enabled.
>>
>> Hi. Ok with a few nits.
>>
>> 1) Since all of these changes are related, don't separate them with
>> blank lines in the changelog entry.
>>
>> 2) Write the configure.ac entry as:
>> * configure.ac (AC_TRY_LIBGUILE): Add a check for
>> scm_set_automatic_finalization_enabled.
>>
>> 3) Include the changelog entry for configure being regenerated, even
>> though it's not included in the patch:
>> * configure: Regenerate.
>
> Updated patch to fix nits. Cheers!
>
> Andy
>
>
> From 4a9919c3e731f0210cfbcfbbb6040189f46a7fbb Mon Sep 17 00:00:00 2001
> From: Andy Wingo <wingo@igalia.com>
> Date: Tue, 10 Feb 2015 15:26:24 +0100
> Subject: [PATCH] [guile] Run finalizers from GDB thread
>
> gdb/ChangeLog:
> * guile/guile.c (_initialize_guile): Disable automatic
> finalization, if Guile offers us that possibility.
> * guile/guile.c (call_initialize_gdb_module):
> * guile/scm-safe-call.c (gdbscm_with_catch): Arrange to run
> finalizers in appropriate places.
> * configure.ac (AC_TRY_LIBGUILE): Add a check for
> scm_set_automatic_finalization_enabled.
> * configure: Regenerated.
Thanks.
LGTM