This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Missing test cases for jit-reader interface
- From: Sanjoy Das <sanjoy at playingwithpointers dot com>
- To: Andy Wingo <wingo at igalia dot com>
- Cc: gdb-patches at sourceware dot org, Jan Kratochvil <jan dot kratochvil at redhat dot com>, sanjoyd at sourceware dot org
- Date: Tue, 24 Feb 2015 23:37:41 -0800
- Subject: Re: Missing test cases for jit-reader interface
- Authentication-results: sourceware.org; auth=none
- References: <87oaolx6xy dot fsf at igalia dot com> <87k2z8ydq4 dot fsf at igalia dot com>
This is definitely my fault, I missed actually adding the files when
making the checkin.
Unfortunately I neither have the necessary context in my head to
review this change nor the right SSH keys to check this in. It will
probably be best if a gdb maintainer takes a look at this.
Thanks,
-- Sanjoy
On Mon, Feb 23, 2015 at 5:11 AM, Andy Wingo <wingo@igalia.com> wrote:
> Hi,
>
> On Mon 23 Feb 2015 11:23, Andy Wingo <wingo@igalia.com> writes:
>
>> In this thread:
>>
>> http://thread.gmane.org/gmane.comp.gdb.patches/80671/focus=82555
>>
>> There were tests for the jit-reader interface that were to be added to
>> the repo, but they didn't seem to make it in:
>>
>> $ git show --stat 675921c059dbaddd02ab2eb8a1eaf77b3ac727dd
>> commit 675921c059dbaddd02ab2eb8a1eaf77b3ac727dd
>> Author: Sanjoy Das <sanjoyd@sourceware.org>
>> Date: Thu Jan 17 14:21:46 2013 +0000
>>
>> gdb/testsuite
>>
>> * gdb.base/jit-reader.exp: New file. Test case for the jit-reader
>> interface.
>> * gdb.base/jithost.c: New file.
>> * gdb.base/jithost.h: New file.
>> * gdb.base/jitreader.c : New file.
>> * gdb.base/jit-protocol.h: New file.
>>
>> gdb/testsuite/ChangeLog | 9 +++++++++
>> 1 file changed, 9 insertions(+)
>>
>> Could it be Jan that you forgot to add the new files when you committed
>> Sanjoy's patch?
>
> I think it was Sanjoy who forgot to commit these. Anyway, here is an
> updated version of the same patch, which passes tests for me. WDYT?
>