This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Fix print of value type in a corner case of finish
- From: Antoine Tremblay <antoine dot tremblay at ericsson dot com>
- To: Pedro Alves <palves at redhat dot com>, <gdb-patches at sourceware dot org>
- Date: Thu, 26 Feb 2015 10:44:09 -0500
- Subject: Re: [PATCH] Fix print of value type in a corner case of finish
- Authentication-results: sourceware.org; auth=none
- References: <1424957146-25705-1-git-send-email-antoine dot tremblay at ericsson dot com> <54EF212E dot 3020602 at redhat dot com> <54EF298B dot 1010906 at ericsson dot com> <54EF3939 dot 2020401 at redhat dot com>
On 02/26/2015 10:18 AM, Pedro Alves wrote:
I think that we make the test return a big enough
structure, we'll hit RETURN_VALUE_STRUCT_CONVENTION on most
architectures (but not x86...)?
Yes that's what led me to believe I needed something arch specific but
indeed it may not totally be..
So the regex here is too lax and missed this bug. Could you
tweak it to make sure some type was output?
Wow I had totally missed that , Thanks!!
Patch v2 coming up in a few secs...
In that patch I check that I actually get the right struct type :)
(I tested the patch by simulating the condition and it works fine)
Regards,
Antoine