This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 1/2] Fast tracepoint for powerpc64le
- From: Pedro Alves <palves at redhat dot com>
- To: Wei-cheng Wang <cole945 at gmail dot com>, uweigand at de dot ibm dot com, gdb-patches at sourceware dot org
- Date: Wed, 04 Mar 2015 17:21:54 +0000
- Subject: Re: [PATCH 1/2] Fast tracepoint for powerpc64le
- Authentication-results: sourceware.org; auth=none
- References: <54E77725 dot 2070707 at gmail dot com>
On 02/20/2015 06:04 PM, Wei-cheng Wang wrote:
> +/* Return the value of register REGNUM. RAW_REGS is collected buffer
> + by jump pad. This function is called by emit_reg. */
> +
> +ULONGEST __attribute__ ((visibility("default"), used))
> +gdb_agent_get_raw_reg (const unsigned char *raw_regs, int regnum)
> +{
> + if (regnum >= PPC_NUM_FT_COLLECT_GREGS)
Meanwhile several C++ patches landed which changed how this
function should be declared. Please make this:
IP_AGENT_EXPORT_FUNC ULONGEST
gdb_agent_get_raw_reg (const unsigned char *raw_regs, int regnum)
{
I think it'd be good to split out the changes that make
ppc gdbserver do Z0 packets too.
(nit: it'd make it easier to identify the different patches in
the series if they had different subjects, which identified their
actual contents. That's ideal for the subjects of the git commits
too, so best do that when submitting the patches already.)
Thanks for working on this!
Pedro Alves