This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/2] Fast tracepoint for powerpc64le
- From: Pedro Alves <palves at redhat dot com>
- To: Wei-cheng Wang <cole945 at gmail dot com>, uweigand at de dot ibm dot com, gdb-patches at sourceware dot org
- Date: Wed, 04 Mar 2015 19:06:11 +0000
- Subject: Re: [PATCH 2/2] Fast tracepoint for powerpc64le
- Authentication-results: sourceware.org; auth=none
- References: <54E77751 dot 2040707 at gmail dot com>
On 02/20/2015 06:05 PM, Wei-cheng Wang wrote:
> gdb/gdbserver/ChangeLog
>
> 2015-02-20 Wei-cheng Wang <cole945@gmail.com>
>
> * tracepoint.c (initialize_tracepoint): Calling jump_pad_area_hint()
> to get where to map gdb_jump_pad_buffer. Remove MAP_FIXED.
Write:
* tracepoint.c (initialize_tracepoint): Call jump_pad_area_hint
to get where to map gdb_jump_pad_buffer. Remove MAP_FIXED.
> * tracepoint.h (jump_pad_area_hint): Add declaration.
> * linux-amd64-ipa.c (jump_pad_area_hint): New function.
> * linux-i386-ipa.c (jump_pad_area_hint): New function.
> * linux-ppc-ipa.c (jump_pad_area_hint): New function.
I'll leave the PPC-specifics to Ulrich, but otherwise this looks
fine to me, with a nit.
>
> +/* Return the address for where to allocate buffer for jump pad.
> + The buffer should be close enough for tracepoints. */
> +
> +uintptr_t
> +jump_pad_area_hint (void)
> +/* Return the address for where to allocate buffer for jump pad.
> + The buffer should be close enough for tracepoints. */
> +
> +uintptr_t
> +jump_pad_area_hint (void)
> +/* Return the address for where to allocate buffer for jump pad.
> + The buffer should be close enough for tracepoints. */
> +
> +uintptr_t
> +jump_pad_area_hint (void)
Could you move this duplicated comments to the declaration
instead? Then in the implementations' comment you can
just write:
/* See tracepoint.h. */
Thanks,
Pedro Alves