This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 3/3 v2] Fast tracepoint for powerpc64le
- From: Pedro Alves <palves at redhat dot com>
- To: Wei-cheng Wang <cole945 at gmail dot com>, uweigand at de dot ibm dot com, gdb-patches at sourceware dot org
- Date: Wed, 04 Mar 2015 19:13:43 +0000
- Subject: Re: [PATCH 3/3 v2] Fast tracepoint for powerpc64le
- Authentication-results: sourceware.org; auth=none
- References: <54EDE9FF dot 3040608 at gmail dot com>
On 02/25/2015 03:27 PM, Wei-cheng Wang wrote:
> @@ -3341,6 +3357,13 @@ rs6000_frame_this_id (struct frame_info *this_frame, void **this_cache,
> {
> struct rs6000_frame_cache *info = rs6000_frame_cache (this_frame,
> this_cache);
> +
> + if (!info->base_p)
> + {
> + (*this_id) = frame_id_build_unavailable_stack (0);
It's best if this fills in the PC too, when possible.
The normal path below this uses get_frame_func (this_frame).
Can we use that here? If that can throw unavailable,
perhaps we could have rs6000_frame_cache save it in the
frame cache object, inside the TRY_CATCH.
Thanks,
Pedro Alves