Re: [PATCH 4/8] remote+docs: software/hardware breakpoint traps

[Pedro Alves <palves at redhat dot com>]

On 02/26/2015 04:50 PM, Eli Zaretskii wrote:

>> +@item swbreak
>> +This feature indicates whether @value{GDBN} supports the swbreak stop
>> +reason in stop replies.  See @xref{swbreak stop reason}, for details.
>> +
>> +@item hwbreak
>> +This feature indicates whether @value{GDBN} supports the hwbreak stop
>> +reason in stop replies.  See @xref{swbreak stop reason}, for details.
>                             ^^^^^^^^^
> @xref should always be at the beginning of a sentence, as it generates
> text that starts with a capital letter.  I think you meant @ref here.

Ah, good catch, thanks.  I just dropped the See and use @xref, which
is the same thing.

> 
>> +If the stub supports non-stop mode, it should also support the
>> +@samp{swbreak} stop reason if software breakpoints are supported, and
>> +the @samp{hwbreak} stop reason if software breakpoints are supported
>                                      ^^^^^^^^
> "hardware", I guess.

Indeed.

> 
> Otherwise, OK for the documentation parts.  Thanks.

I fixed another typo I notice, and push it in, with this merged in:

diff --git i/gdb/doc/gdb.texinfo w/gdb/doc/gdb.texinfo
index 72fa86c7..4b76ce9 100644
--- i/gdb/doc/gdb.texinfo
+++ w/gdb/doc/gdb.texinfo
@@ -35214,7 +35214,7 @@ breakpoint address plus an offset.  On such targets, the stub is
 responsible for adjusting the PC to point back at the breakpoint
 address.

-This packet should be not sent by default; older @value{GDBN} versions
+This packet should not be sent by default; older @value{GDBN} versions
 did not support it.  @value{GDBN} requests it, by supplying an
 appropriate @samp{qSupported} feature (@pxref{qSupported}).  The
 remote stub must also supply the appropriate @samp{qSupported} feature
@@ -35815,11 +35815,11 @@ instruction reply packet}).

 @item swbreak
 This feature indicates whether @value{GDBN} supports the swbreak stop
-reason in stop replies.  See @xref{swbreak stop reason}, for details.
+reason in stop replies.  @xref{swbreak stop reason}, for details.

 @item hwbreak
 This feature indicates whether @value{GDBN} supports the hwbreak stop
-reason in stop replies.  See @xref{swbreak stop reason}, for details.
+reason in stop replies.  @xref{swbreak stop reason}, for details.
 @end table

 Stubs should ignore any unknown values for
@@ -37633,7 +37633,7 @@ or if the target is not attached to any process, it shall respond

 If the stub supports non-stop mode, it should also support the
 @samp{swbreak} stop reason if software breakpoints are supported, and
-the @samp{hwbreak} stop reason if software breakpoints are supported
+the @samp{hwbreak} stop reason if hardware breakpoints are supported
 (@pxref{swbreak stop reason}).  This is because given the asynchronous
 nature of non-stop mode, between the time a thread hits a breakpoint
 and the time the event is finally processed by @value{GDBN}, the