This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2] Python API: Fix an exception when registering a global pretty-printer in verbose mode
- From: Martin Galvan <martin dot galvan at tallertechnologies dot com>
- To: Doug Evans <dje at google dot com>
- Cc: gdb-patches <gdb-patches at sourceware dot org>
- Date: Wed, 11 Mar 2015 21:24:55 -0300
- Subject: Re: [PATCH v2] Python API: Fix an exception when registering a global pretty-printer in verbose mode
- Authentication-results: sourceware.org; auth=none
- References: <1426097817-30955-1-git-send-email-martin dot galvan at tallertechnologies dot com> <21760 dot 54598 dot 126480 dot 383468 at ruffy2 dot mtv dot corp dot google dot com>
On Wed, Mar 11, 2015 at 8:52 PM, Doug Evans <dje@google.com> wrote:
> LGTM, with two more nits.
> The ChangeLog entry > 80 char limit :-),
> and convention is to include the function name in the ChangeLog entry.
>
> E.g.,
>
> 2015-03-11 Martin Galvan <martin.galvan@tallertechnologies.com>
>
> * python/lib/gdb/printing.py (register_pretty_printer): Fix exception
> when registering a global pretty-printer in verbose mode.
>
> No need to repost though.
> Ok to commit with that fixed.
Thanks a lot! I'll keep that in mind for any future patches.