This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2] Improve corefile generation by using /proc/PID/coredump_filter (PR corefile/16902)
- From: Sergio Durigan Junior <sergiodj at redhat dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: GDB Patches <gdb-patches at sourceware dot org>, Jan Kratochvil <jan dot kratochvil at redhat dot com>, Oleg Nesterov <oleg at redhat dot com>
- Date: Wed, 18 Mar 2015 15:39:54 -0400
- Subject: Re: [PATCH v2] Improve corefile generation by using /proc/PID/coredump_filter (PR corefile/16902)
- Authentication-results: sourceware.org; auth=none
- References: <878ufc9kau dot fsf at redhat dot com> <87r3stnbdw dot fsf at redhat dot com> <55033BD3 dot 8060800 at redhat dot com> <871tko8pom dot fsf at redhat dot com> <5509CD9F dot 8060803 at redhat dot com>
On Wednesday, March 18 2015, Pedro Alves wrote:
> On 03/16/2015 11:53 PM, Sergio Durigan Junior wrote:
>
>> To summarize: I decided to change this part of the code, and make GDB
>> actually ignore (i.e., return 0) mappings marked as UNMODIFIED. After
>> all, as explained above, this is what Linux does.
>
> I can't tell whether we'll still need the UNKNOWN state after that,
> but offhand, if a mapping isn't supposed to be dumped, why not
> just skip calling the callback (gcore_create_callback)?
That is another option. Initially we would call gcore_create_callback
because at least the segment header should be created in the corefile;
however, as I mentioned before, Linux doesn't do that (therefore GDB
shouldn't too).
--
Sergio
GPG key ID: 0x65FC5E36
Please send encrypted e-mail if possible
http://sergiodj.net/