This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch 1/2] mingw: update gnulib: prepare the sources
- From: Pedro Alves <palves at redhat dot com>
- To: Eli Zaretskii <eliz at gnu dot org>
- Cc: jan dot kratochvil at redhat dot com, ktietz at redhat dot com, gdb-patches at sourceware dot org, vinschen at redhat dot com, nickc at redhat dot com
- Date: Mon, 23 Mar 2015 17:57:52 +0000
- Subject: Re: [patch 1/2] mingw: update gnulib: prepare the sources
- Authentication-results: sourceware.org; auth=none
- References: <20141222221229 dot GA30575 at host2 dot jankratochvil dot net> <108241234 dot 1319759 dot 1419335690162 dot JavaMail dot zimbra at redhat dot com> <20141224222045 dot GA30482 at host2 dot jankratochvil dot net> <551044A0 dot 9070607 at redhat dot com> <20150323170830 dot GA8493 at host1 dot jankratochvil dot net> <55104C7B dot 9060405 at redhat dot com> <83mw33r4y3 dot fsf at gnu dot org>
On 03/23/2015 05:36 PM, Eli Zaretskii wrote:
>> Date: Mon, 23 Mar 2015 17:25:15 +0000
>> From: Pedro Alves <palves@redhat.com>
>> CC: Kai Tietz <ktietz@redhat.com>, gdb-patches@sourceware.org, Corinna Vinschen <vinschen@redhat.com>, Nicholas Clifton <nickc@redhat.com>
>>
>>> With this header file used for GDB's sources aren't gnulib's .c files compiled
>>> with incompatible ABI?
>>
>> Other than rpl_gettimeofday (the gettimeofday replacement):
>>
>> gettimeofday.o:0000005a T _rpl_gettimeofday
>>
>> AFAICS, there's no other use of "struct timeval" or gettimeofday in gnulib's
>> sources.
>
> We should watch out for Gnulib's 'select' and friends, if we ever want
> to import that. Also 'utimens'.
Agreed.
I think it's good to first go with this simple approach to unblock a
gnulib import, and then we can always do some more invasive fix on
top, with no rush.
However, it'd be good if someone could make sure that gdb
still actually works on Windows before pushing to master.
I've pushed a gnulib import to current gnulib git to the
users/palves/gnulib-update branch (on sourceware.org).
Can anyone give it a try on Windows? All I can easily
test is building..
Thanks,
Pedro Alves