This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 1/8] Add --with-system-zlib in bfd

From: Mike Frysinger <vapier at gentoo dot org>
To: "H.J. Lu" <hjl dot tools at gmail dot com>
Cc: binutils at sourceware dot org, GDB <gdb-patches at sourceware dot org>
Date: Tue, 31 Mar 2015 02:13:37 -0400
Subject: Re: [PATCH 1/8] Add --with-system-zlib in bfd
Authentication-results: sourceware.org; auth=none
References: <20150326155711 dot GA10088 at gmail dot com>

On 26 Mar 2015 08:57, H.J. Lu wrote:
> --- a/bfd/configure.ac
> +++ b/bfd/configure.ac
>  
> -# Link in zlib if we can.  This allows us to read compressed debug sections.
> -# This is used only by compress.c.
> -AM_ZLIB
> +# Use the system's zlib library.
> +zlibdir=-L../zlib
> +zlibinc="-I\$(srcdir)/../zlib"
> +AC_ARG_WITH(system-zlib,
> +[AS_HELP_STRING([--with-system-zlib], [use installed libz])],
> +zlibdir=
> +zlibinc=
> +)

this is wrong.  the 3rd arg is whether the option was specified, not that the 
option was disabled.  you need to check $withval is equal to "no" (or not equal 
to "yes").
-mike

Attachment: signature.asc
Description: Digital signature

Follow-Ups:
- Re: [PATCH 1/8] Add --with-system-zlib in bfd
  - From: H.J. Lu

References:
- [PATCH 1/8] Add --with-system-zlib in bfd
  - From: H.J. Lu

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]