This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 8/9] Make the default sysroot be "target:"
- From: Gary Benson <gbenson at redhat dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 1 Apr 2015 15:12:46 +0100
- Subject: Re: [PATCH 8/9] Make the default sysroot be "target:"
- Authentication-results: sourceware.org; auth=none
- References: <1426870087-32654-1-git-send-email-gbenson at redhat dot com> <1426870087-32654-9-git-send-email-gbenson at redhat dot com> <551BE151 dot 4070900 at redhat dot com>
Pedro Alves wrote:
> On 03/20/2015 04:48 PM, Gary Benson wrote:
> > This commit makes GDB default to a sysroot of "target:".
> > One testcase needed updating as a result of this change.
>
> That's because when the sysroot is "target:" and the filesystem is
> remote, the sysroot is stripped from the "Inferior loaded" message,
> right? A short comment in the test would help.
>
> OK with that change.
I reorganized this a little while adding the comment.
I'll commit this:
diff --git a/gdb/testsuite/gdb.base/break-probes.exp...
index 1591c33..23aca8f 100644
--- a/gdb/testsuite/gdb.base/break-probes.exp
+++ b/gdb/testsuite/gdb.base/break-probes.exp
@@ -66,6 +66,10 @@ if { $using_probes } {
}
}
+ # GDB strips "target:" from the start of filenames when
+ # operating on the local filesystem
+ regsub "^target:" "$sysroot" "(target:)?" sysroot
+
# Run til it loads our library
set test "run til our library loads"
set not_loaded_library 1
Cheers,
Gary
--
http://gbenson.net/