This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Build failure following: Implement support for checking /proc/PID/coredump_filter commit
- From: Pedro Alves <palves at redhat dot com>
- To: Pierre Muller <pierre dot muller at ics-cnrs dot unistra dot fr>, "'Sergio Durigan Junior'" <sergiodj at redhat dot com>
- Cc: "'GDB Patches'" <gdb-patches at sourceware dot org>
- Date: Wed, 08 Apr 2015 15:43:42 +0100
- Subject: Re: Build failure following: Implement support for checking /proc/PID/coredump_filter commit
- Authentication-results: sourceware.org; auth=none
- References: <1427241443-5939-1-git-send-email-sergiodj at redhat dot com> <1427241443-5939-2-git-send-email-sergiodj at redhat dot com> <5515289D dot 1000006 at redhat dot com> <874mp0vir0 dot fsf at redhat dot com> <000001d07205$69de1770$3d9a4650$ at muller@ics-cnrs.unistra.fr>
On 04/08/2015 03:07 PM, Pierre Muller wrote:
> Or maybe we should use the gnulib version of strtok_r?
Yes.
> I don't really know how to do this, but if someone can tell me,
> I can test the patch.
Let me give that a try, and I'll post a branch for you to test.
There's also the "users/palves/gnulib-update" branch that
updates gdb's copy of gnulib to recent gnulib master. It'd
be great if someone confirmed that a gdb build of that branch
actually works on Windows, so we can move forward with that.
(the branch predates Sergio's patch, so isn't affected by the strtok_r
issue). I'd be nice to update our gnulib copy before we pull in
more modules, to avoid tripping on bugs that have meanwhile already
been fixed upstream, or avoid module dependencies that may
have been reduced upstream...
Thanks,
Pedro Alves