This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Fix Python completion when using the "complete" command
- From: Sergio Durigan Junior <sergiodj at redhat dot com>
- To: Doug Evans <dje at google dot com>
- Cc: Keith Seitz <keiths at redhat dot com>, GDB Patches <gdb-patches at sourceware dot org>
- Date: Wed, 08 Apr 2015 18:29:08 -0400
- Subject: Re: [PATCH] Fix Python completion when using the "complete" command
- Authentication-results: sourceware.org; auth=none
- References: <87d23ovk55 dot fsf at redhat dot com> <87ego4txco dot fsf at redhat dot com> <87vbh74uqd dot fsf at redhat dot com> <55257877 dot 3040604 at redhat dot com> <87384a1jeo dot fsf at redhat dot com> <21797 dot 37361 dot 185090 dot 321060 at ruffy2 dot mtv dot corp dot google dot com>
On Wednesday, April 08 2015, Doug Evans wrote:
> > + resultobj = PyObject_CallMethodObjArgs ((PyObject *) obj, complete_cst,
> > + textobj, wordobj, NULL);
> > + Py_DECREF (textobj);
> > + Py_DECREF (wordobj);
> > + if (!resultobj)
> > + {
> > + /* Just swallow errors here. */
> > + PyErr_Clear ();
> > }
>
> I realize this is just copying the previous code,
> but does swallowing errors here make it hard to debug problems
> in the completer function?
> Is this something we want to address in a future patch?
Thanks for the review, Doug.
You have a valid point: swallowing errors in this part of the code does
make it hard to debug problems in the user-provided completer
functions. And a small hack in the code proved me that it should be
fairly easy to print the error instead, just like cmdpy_function already
does. I will see if I can prepare a patch to do that.
Meanwhile, I pushed the current patch upstream.
<https://sourceware.org/ml/gdb-cvs/2015-04/msg00062.html>
6d62641c832525382336c1b04731d85cb6c398e7
Thanks,
--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/