Re: [doc patch] compile: missing bits [Re: [PATCH v2 7/9] compile: New 'compile print']

[Eli Zaretskii <eliz at gnu dot org>]

> Date: Thu, 9 Apr 2015 19:39:50 +0200
> From: Jan Kratochvil <jan.kratochvil@redhat.com>
> Cc: Paul_Koning@dell.com, gdb-patches@sourceware.org, pmuldoon@redhat.com
> 
> On Thu, 09 Apr 2015 09:39:46 +0200, Eli Zaretskii wrote:
> > So I think we should tell the story in the manual, yes.
> 
> there were various missing bits for the 'compile' feature so adding them here.

Thanks.

> +@value{GDBN} needs to specify the right compilation options for the code
> +to be injected.  In part to make its ABI compatible with the inferior
> +and in part to make the injected code compatible with GDB's injecting
> +process.

The second sentence is not a complete sentence; suggest to make it
part of the first (as in "...to be injected, in part to make its
ABI...").

Also, there's a bare "GDB" there.

> +@value{NGCC} (since version 4.7) stores the options used for compilation
> +into @code{DW_AT_producer} part of DWARF debugging information according
> +to the @value{NGCC} option @code{-grecord-gcc-switches}.  One has to
> +explicitly specify @code{-g} during inferior compilation otherwise
> +@value{NGCC} produces no DWARF.

Hmm...  Are you sure -g always produces DWARF?  Maybe we should say
that for targets where DWARF is not the default, -gdwarf-N should be
used, and also that -gstabs etc. should _not_ be used?

> +@item set compile-args
> +@value{GDBN} contains default compilation options to set and possibly
> +override the options required for proper injection of the compiled code.
> +@end table
> +
> +@noindent
> +The options mentioned last can be specified with command:
> +
> +@table @code
> +@item set compile-args

This is slightly confusing.  I suggest the following text instead:

 @item compilation options set by @code{set compile-args}
 @end table

 @noindent
 You can override compilation options using the following command:

 @table @code
 @item set compile-args
 @cindex compile command options override
 Set compilation options used for compiling and injecting code with the
 @code{compile} commands.  These options override any conflicting ones
 from the target architecture and/or options stored during inferior
 compilation.
 
 @item show compile-args
 Displays the current state of compilation options override.
 This does not show all the options actually used during compilation,
 use @ref{set debug compile} for that.
 @end table

> +@value{GDBN} needs to find @value{NGCC} for the inferior being debugged which
> +may not be obvious for remote targets of different architecture than where
> +@value{GDBN} is running.  Environment variable @code{PATH} (@code{PATH} from
> +shell that executed @value{GDBN}, not the one set by @value{GDBN}
> +command @code{set environment}.  @xref{Environment}.  @code{PATH} on

There's a right parenthesis missing here.

> +Specifically @code{PATH} is searched for binaries matching regular expression
> +@code{@var{ARCH}(-[^-]*)?-@var{OS}-gcc} according to the inferior target being
> +debugged.  @code{@var{ARCH}} is processor name - multiarch is supported,

Please don't up-case ARCH and OS, makeinfo will do that when needed.

Also, please use "---" instead of just one dash.

> +for pattern @code{s390x?}.  @code{OS} is currently supported only for
>                              ^^^^^^^^^

@var{os}.