Re: [PATCH 7/7] Access executable from remote system when first inferior appears

[Pedro Alves <palves at redhat dot com>]

On 04/15/2015 02:55 PM, Gary Benson wrote:
> Pedro Alves wrote:
>> On 04/01/2015 12:22 PM, Gary Benson wrote:
>>> This commit modifies remote_add_inferior to take an extra argument
>>> try_open_exec.  If this is nonzero, remote_add_inferior will
>>> attempt to open this inferior's executable as the main executable
>>> if no main executable is open already.  Callers are updated
>>> appropriately.
>>>
>>> One testcase required updating as a result of this commit.  The
>>> test checked that GDB's "info files" command does not crash if no
>>> main executable is open, and relied on GDB's inability to access
>>> the main executable over the remote protocol.  The test was
>>> updated to inhibit this new behavior.
>>
>> So this is significant user-visible change too.  I think it deserves
>> an example in the commit log, and a NEWS entry.  The manual should
>> probably be updated to explain/mention this too.  We already mention
>> something like this in the "attach" docs:
>>
>>   "When you use @code{attach}, the debugger finds the program running in
>>   the process first (...)"
> 
> How about these?
> 
> diff --git a/gdb/NEWS b/gdb/NEWS
> index b11a6fc..e88210f 100644
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -36,6 +36,11 @@
>    the operating system) when starting processes remotely, and when
>    attaching to already-running local or remote processes.
>  
> +* GDB now supports automatic location and retrieval of executable
> +  files from remote targets.  Remote debugging can now be initiated
> +  using only a "target remote" or "target extended-remote" command
> +  (no "set sysroot" or "file" commands are required).

LGTM, though it should probably say

  See "New remote packets" below/above.

too, to hint that this needs remote target support.  It's what we
did in the range-stepping NEWS entry, for example.

Thanks,
Pedro Alves