This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 6/7] Implement multiple-filesystem support for remote targets


On 04/17/2015 04:59 PM, Gary Benson wrote:
> Pedro Alves wrote:
>> On 04/16/2015 01:19 PM, Gary Benson wrote:
>>> --- a/gdb/remote.c
>>> +++ b/gdb/remote.c
>>> @@ -367,6 +367,12 @@ struct remote_state
>>>  
>>>    /* The branch trace configuration.  */
>>>    struct btrace_config btrace_config;
>>> +
>>> +  /* The argument to the last "vFile:setfs:" packet we sent, used
>>> +     to avoid sending repeated unnecessary "vFile:setfs:" packets.
>>> +     Initialized to -1 to indicate that no "vFile:setfs:" packet
>>> +     has yet been sent.  */
>>> +  int fs_pid;
>>>  };
>>>  
>>
>>> +/* Process ID of inferior whose filesystem remote_hostio functions
>>> +   that take FILENAME arguments will use.  Zero means to use the
>>> +   remote stub's filesystem.  */
>>> +
>>> +static int remote_fs_pid = 0;
>>
>> What's the rationale for not putting this one in "struct
>> remote_state" ?
> 
> I don't have one :)  Would you prefer it there?

It's not really about personal preference: if on a
multi-remote-connections world the flag would be remote connection
specific, it should be in remote_state.  It seemed that way
to me, but if it isn't, then it should be left a global.

Thanks,
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]