This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Fixes to Cygwin-specific signal handling
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Jon TURNEY <jon dot turney at dronecode dot org dot uk>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 22 Apr 2015 07:23:17 -0700
- Subject: Re: [PATCH] Fixes to Cygwin-specific signal handling
- Authentication-results: sourceware.org; auth=none
- References: <1429009382-21040-1-git-send-email-jon dot turney at dronecode dot org dot uk> <20150414131615 dot GI4704 at adacore dot com> <55300C61 dot 2080102 at dronecode dot org dot uk>
> > current_thread = th;
> > if (!current_thread)
> > thread_rec (thread_id, TRUE);
>
> I've done this (with the last line as an assignment), but you'll
> have to help me find where the Coding Standard says that.
>
> [1] mentions not using assignments inside if conditions, but I don't
> see any mention of ?:
>
> [1] http://www.gnu.org/prep/standards/standards.html#Syntactic-Conventions
I think I got slightly confused by that one, as to what the "?"
applied to. But I guess that could be seen as a good reason for
avoiding it in this case :-P. Thanks for doing it anyways, even
though the reasons for it were not as strong as I thought.
--
Joel