This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v3 05/17] Embed the pending step-over chain in thread_info objects
- From: Pedro Alves <palves at redhat dot com>
- To: Doug Evans <dje at google dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 22 Apr 2015 23:19:18 +0100
- Subject: Re: [PATCH v3 05/17] Embed the pending step-over chain in thread_info objects
- Authentication-results: sourceware.org; auth=none
- References: <1429267521-21047-1-git-send-email-palves at redhat dot com> <1429267521-21047-6-git-send-email-palves at redhat dot com> <21815 dot 8859 dot 290139 dot 116294 at ruffy2 dot mtv dot corp dot google dot com>
On 04/22/2015 05:24 AM, Doug Evans wrote:
> > --- a/gdb/infrun.c
> > +++ b/gdb/infrun.c
> >...
> > @@ -1855,24 +1842,44 @@ displaced_step_fixup (ptid_t event_ptid, enum gdb_signal signal)
> > do_cleanups (old_cleanups);
> >
> > displaced->step_ptid = null_ptid;
> > +}
> >
> > - /* Are there any pending displaced stepping requests? If so, run
> > - one now. Leave the state object around, since we're likely to
> > - need it again soon. */
> > - while (displaced->step_request_queue)
> > +/* Are there any pending step-over requests? If so, run one now. */
>
> Hi.
>
> Nit: IIUC "run one now" should read "run all we can now".
Thanks, I did that change.
--
Pedro Alves