This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/3] Update our idea of our terminal's dimensions even outside of TUI
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Patrick Palka <patrick at parcs dot ath dot cx>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 24 Apr 2015 09:49:09 -0700
- Subject: Re: [PATCH 2/3] Update our idea of our terminal's dimensions even outside of TUI
- Authentication-results: sourceware.org; auth=none
- References: <1429836801-14218-1-git-send-email-patrick at parcs dot ath dot cx> <1429836801-14218-2-git-send-email-patrick at parcs dot ath dot cx>
> When in the CLI, GDB's "width" and "height" variables are not kept in sync
> when the underlying terminal gets resized.
>
> This patch fixes this issue by making sure sure to update GDB's "width"
> and "height" variables in the !tui_active case of our SIGWINCH handler.
>
> gdb/ChangeLog:
>
> * tui/tui-win.c (tui_sigwinch_handler): Remove now-stale comment.
> (tui_sigwinch_handler): Still update our idea of
> the terminal's width and height even when TUI is not active.
Neat. Thanks for this nice little enhancement!
I've only glanced at the patch, as I'm not a specialist of this area
and Pedro has been pretty active there and would do a much better job
than I would. But if Pedro can't make it, I'm sure I could set some
time aside to review it a little more carefully.
--
Joel