This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/6] DWARF Two Level Line Tables: dwarf2_line_debug
- From: Doug Evans <dje at google dot com>
- To: Eli Zaretskii <eliz at gnu dot org>
- Cc: gdb-patches <gdb-patches at sourceware dot org>, Cary Coutant <ccoutant at google dot com>
- Date: Tue, 12 May 2015 13:39:27 -0700
- Subject: Re: [PATCH 2/6] DWARF Two Level Line Tables: dwarf2_line_debug
- Authentication-results: sourceware.org; auth=none
- References: <yjt28uf27zo2 dot fsf at ruffy dot mtv dot corp dot google dot com> <83a8zi3qar dot fsf at gnu dot org>
On Thu, Mar 12, 2015 at 1:37 PM, Eli Zaretskii <eliz@gnu.org> wrote:
>> From: Doug Evans <dje@google.com>
>> cc: ccoutant@google.com
>> Date: Thu, 12 Mar 2015 13:01:49 -0700
>>
>> --- a/gdb/NEWS
>> +++ b/gdb/NEWS
>> @@ -30,6 +30,10 @@ record bts
>>
>> * New options
>>
>> +set debug dwarf2-line
>> +show debug dwarf2-line
>> + Control display of debugging info regarding DWARF line processing.
>
> This is OK.
>
>> --- a/gdb/doc/gdb.texinfo
>> +++ b/gdb/doc/gdb.texinfo
>> @@ -23245,6 +23245,14 @@ The value is the number of nesting levels to print.
>> A value of zero turns off the display.
>> @item show debug dwarf2-die
>> Show the current state of DWARF2 DIE debugging.
>> +@item set debug dwarf2-line
>> +@cindex DWARF2 Line Tables
>> +Turns on or off display of debugging messages related to reading
>> +DWARF line tables. The default is 0 (off).
>> +A value of 1 provides basic information.
>> +A value greater than 1 provides more verbose information.
>> +@item show debug dwarf2-line
>> +Show the current state of DWARF2 line table debugging.
>
> This is also OK, but how about using "DWARF2" for consistency at least
> in this fragment?
Actually, I'd rather use "DWARF".
There's a lot of history/inertia here that we should really overcome
and put behind us.
We call things DWARF2 to disambiguate from DWARF1 (which no longer
exists in any useful form). dwarf2read.c should *really* be
dwarfread.c IMO (and so on for every other instance of
dwarf2/DWARF2/dw2/etc. in file names, code, docs, etc.)
> (Btw, I find this "DWARF2", "DWARF 4", "DWARF 5" thing utterly
> confusing for the reader; the truth is "DWARF version 5" etc. I wish
> we started using that throughout.)
Agreed. Where the version doesn't matter I propose using "DWARF".
(as in the above)