This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 5/6] Remove stop_registers


I'll comment on patch #4 once I grok it fully, but meanwhile...

> --- a/gdb/infcmd.c
> +++ b/gdb/infcmd.c
> @@ -1519,7 +1519,7 @@ get_return_value (struct value *function, struct type *value_type,
>    struct value *value;
>    struct cleanup *cleanup = make_cleanup (null_cleanup, NULL);
>  
> -  /* If stop_registers were not saved, use the current registers.  */
> +  /* If were not saved, use the current registers.  */

A word after "If" is missing, I guess:

"If registers were not saved, ..."

Otherwise looks fine.

This variable should probably be renamed and its comments
further clarified, but what you have is good already.  We can
do that separately.

Thanks,
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]