This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 5/6] Remove stop_registers
- From: Pedro Alves <palves at redhat dot com>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>, gdb-patches at sourceware dot org
- Date: Wed, 13 May 2015 14:10:15 +0100
- Subject: Re: [PATCH 5/6] Remove stop_registers
- Authentication-results: sourceware.org; auth=none
- References: <20150508202119 dot 15830 dot 18218 dot stgit at host1 dot jankratochvil dot net> <20150508202152 dot 15830 dot 73823 dot stgit at host1 dot jankratochvil dot net>
I'll comment on patch #4 once I grok it fully, but meanwhile...
> --- a/gdb/infcmd.c
> +++ b/gdb/infcmd.c
> @@ -1519,7 +1519,7 @@ get_return_value (struct value *function, struct type *value_type,
> struct value *value;
> struct cleanup *cleanup = make_cleanup (null_cleanup, NULL);
>
> - /* If stop_registers were not saved, use the current registers. */
> + /* If were not saved, use the current registers. */
A word after "If" is missing, I guess:
"If registers were not saved, ..."
Otherwise looks fine.
This variable should probably be renamed and its comments
further clarified, but what you have is good already. We can
do that separately.
Thanks,
Pedro Alves