This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 6/6] Make regcache_cpy_no_passthrough static
- From: Pedro Alves <palves at redhat dot com>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>, gdb-patches at sourceware dot org
- Date: Wed, 13 May 2015 14:16:42 +0100
- Subject: Re: [PATCH 6/6] Make regcache_cpy_no_passthrough static
- Authentication-results: sourceware.org; auth=none
- References: <20150508202119 dot 15830 dot 18218 dot stgit at host1 dot jankratochvil dot net> <20150508202159 dot 15830 dot 97494 dot stgit at host1 dot jankratochvil dot net>
On 05/08/2015 09:21 PM, Jan Kratochvil wrote:
> +/* Copy/duplicate the contents of a register cache. By default, the
> + operation is pass-through. Writes to DST and reads from SRC will
> + go through to the target. See also regcache_cpy.
> +
> + It can not have overlapping SRC and DST buffers.
> +
> + It does not go through to the target. It only transfer values
> + already in the cache. */
I think this would be clearer:
/* Copy/duplicate the contents of a register cache. Unlike regcache_cpy,
which is pass-through, this does not go through to the target.
Only values values already in the cache are transferred. The SRC and DST
buffers must not overlap. */
static void
regcache_cpy_no_passthrough (struct regcache *dst, struct regcache *src)
{
Otherwise looks fine.
Thanks,
Pedro Alves