This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Move vgdb special case into remote_filesystem_is_local
- From: Gary Benson <gbenson at redhat dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 15 May 2015 10:02:11 +0100
- Subject: Re: [PATCH] Move vgdb special case into remote_filesystem_is_local
- Authentication-results: sourceware.org; auth=none
- References: <1430146276-15606-1-git-send-email-gbenson at redhat dot com> <55547C8B dot 5050000 at redhat dot com>
Pedro Alves wrote:
> On 04/27/2015 03:51 PM, Gary Benson wrote:
> > Valgrind GDB (vgdb) presents itself as a remote target but works
> > on the local filesystem. gdb_bfd_open contained a special case
> > to make vgdb work with "target:" sysroots, but the implementation
> > meant that GDB would fall back to the local filesystem if *any*
> > to_fileio_open method failed with ENOSYS for *any* reason.
>
> Can you give an example target where we'd want this to behave
> differently?
>
> E.g,. what should happen with "target sim" ?
I don't understand what you're asking. "target sim" doesn't use
remote_filesystem_is_local, (to_filesystem_is_local for sim is
the default, tdefault_filesystem_is_local, which returns 1 always).
> > This commit moves the vgdb special case to
> > remote_filesystem_is_local to allow the fallback to be restricted
> > only to the specific case that remote file transfer is
> > unsupported. This commit also adds a warning which is displayed
> > the first time the fallback is used.
Thanks,
Gary
--
http://gbenson.net/