This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v5 5/7] Code cleanup: compile: func_addr -> func_sym
- From: Pedro Alves <palves at redhat dot com>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>, gdb-patches at sourceware dot org
- Cc: Phil Muldoon <pmuldoon at redhat dot com>
- Date: Fri, 15 May 2015 17:51:38 +0100
- Subject: Re: [PATCH v5 5/7] Code cleanup: compile: func_addr -> func_sym
- Authentication-results: sourceware.org; auth=none
- References: <20150513201615 dot 4051 dot 5261 dot stgit at host1 dot jankratochvil dot net> <20150513201656 dot 4051 dot 30357 dot stgit at host1 dot jankratochvil dot net>
On 05/13/2015 09:16 PM, Jan Kratochvil wrote:
> Hi,
>
> currently the code fetches _gdb_expr address/types at multiple places, guessing
> its parameters at multiple places etc.
>
> Fetch it once, verify it has expected type and then rely on it.
>
> While the patch tries to clean up the code it is still horrible due to the
> missing C++ sub-classing.
>
OK.
Thanks,
Pedro Alves