This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v5 5/7] Code cleanup: compile: func_addr -> func_sym


On 05/13/2015 09:16 PM, Jan Kratochvil wrote:
> Hi,
> 
> currently the code fetches _gdb_expr address/types at multiple places, guessing
> its parameters at multiple places etc.
> 
> Fetch it once, verify it has expected type and then rely on it.
> 
> While the patch tries to clean up the code it is still horrible due to the
> missing C++ sub-classing.
> 

OK.

Thanks,
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]