This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Do arm_abi detection for ELFOSABI_GNU binaries
- From: Kyle Huey <me at kylehuey dot com>
- To: Yao Qi <qiyaoltc at gmail dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 19 May 2015 07:04:09 -0700
- Subject: Re: [PATCH] Do arm_abi detection for ELFOSABI_GNU binaries
- Authentication-results: sourceware.org; auth=none
- References: <CAP045ApGo8tPc=97OqrVG4S9GiAP+T1k0ftrP2L3f-kpCDSdJg at mail dot gmail dot com> <86sibzrvtv dot fsf at gmail dot com> <CAP045ApZ9xcDwDk45CXcd=0gxhqsTcUcJ9jAER4RkRn1RCs_Vg at mail dot gmail dot com> <86fv6ssy3v dot fsf at gmail dot com>
On Tue, May 19, 2015 at 2:41 AM, Yao Qi <qiyaoltc@gmail.com> wrote:
> Kyle Huey <me@kylehuey.com> writes:
>
>> Thank you for the tip. Have you had a chance to look at the patch?
>
> Hi Kyle,
> Sorry for the delayed reply. I spent some hours investigating how this
> patch break some cases, but can't find any one. I also take a look at
> code in binutils, and find the code pattern
> "e_ident[EI_OSABI] == ELFOSABI_GNU || e_ident[EI_OSABI] == ELFOSABI_NONE"
> is used here and there.
>
> This patch is OK to commit. If you don't have a sourceware account to
> push your commit in, I can do it for you. Your patch is just one line,
> so it can be pushed in as a "tiny patch".
>
> --
> Yao (éå)
Thanks for reviewing! I do not have a sourceware account, so that
would be greatly appreciated.
Thanks,
- Kyle