This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/4] Implements aarch64 process record and reverse debugging support
- From: Edjunior Barbosa Machado <emachado at linux dot vnet dot ibm dot com>
- To: Yao Qi <qiyaoltc at gmail dot com>, Pedro Alves <palves at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 26 May 2015 17:00:41 -0300
- Subject: Re: [PATCH 2/4] Implements aarch64 process record and reverse debugging support
- Authentication-results: sourceware.org; auth=none
- References: <1432041752-4638-1-git-send-email-yao dot qi at linaro dot org> <1432041752-4638-3-git-send-email-yao dot qi at linaro dot org> <555E3EAE dot 2080107 at redhat dot com> <86h9qzr2g2 dot fsf at gmail dot com>
On 05/26/2015 08:41 AM, Yao Qi wrote:
> Pedro Alves <palves@redhat.com> writes:
>
>> Off by one?
>>
> Oh, good catch. It should be:
>
> * linux-record.h (struct linux_record_tdep) <arg7>: New field.
>
>> Looked fine to me otherwise (I just skimmed it; didn't really look at
>> anything aarch64 specific in detail).
>
> Thanks for looking at them... I'll push them in.
>
Hi,
noticed this commit (99afc8) introduced this issue when checking for uninitialized vars:
gcc -g -O2 -mminimal-toc -I. -I../../gdb -I../../gdb/common -I../../gdb/config -DLOCALEDIR="\"/usr/local/share/locale\"" -DHAVE_CONFIG_H -I../../gdb/../include/opcode -I../../gdb/../opcodes/.. -I../../gdb/../readline/.. -I../../gdb/../zlib -I../bfd -I../../gdb/../bfd -I../../gdb/../include -I../libdecnumber -I../../gdb/../libdecnumber -I../../gdb/gnulib/import -Ibuild-gnulib/import -DTUI=1 -I/usr/include/python2.7 -I/usr/include/python2.7 -Wall -Wpointer-arith -Wno-unused -Wunused-value -Wunused-function -Wno-switch -Wno-char-subscripts -Wempty-body -Wpointer-sign -Wmissing-prototypes -Wdeclaration-after-statement -Wmissing-parameter-type -Wold-style-declaration -Wold-style-definition -Wformat-nonliteral -Werror -c -o aarch64-tdep.o -MT aarch64-tdep.o -MMD -MP -MF .deps/aarch64-tdep.Tpo ../../gdb/aarch64-tdep.c
../../gdb/aarch64-tdep.c: In function âaarch64_process_recordâ:
../../gdb/aarch64-tdep.c:2823:23: error: ârecord_buf[0]â may be used uninitialized in this function [-Werror=maybe-uninitialized]
memcpy(®S[0], &RECORD_BUF[0], sizeof(uint32_t)*LENGTH); \
^
../../gdb/aarch64-tdep.c:3529:12: note: ârecord_buf[0]â was declared here
uint32_t record_buf[2];
^
The simple patch below intends to fix this. Ok?
Thanks,
--
Edjunior
2015-05-26 Edjunior Barbosa Machado <emachado@linux.vnet.ibm.com>
* aarch64-tdep.c: (aarch64_record_data_proc_simd_fp) Avoid uninitialized
variable warning.
diff --git a/gdb/aarch64-tdep.c b/gdb/aarch64-tdep.c
index 8597497..73a7f99 100644
--- a/gdb/aarch64-tdep.c
+++ b/gdb/aarch64-tdep.c
@@ -3526,7 +3526,7 @@ aarch64_record_data_proc_simd_fp (insn_decode_record *aarch64_insn_r)
uint8_t insn_bit21, opcode, rmode, reg_rd;
uint8_t insn_bits24_27, insn_bits28_31, insn_bits10_11, insn_bits12_15;
uint8_t insn_bits11_14;
- uint32_t record_buf[2];
+ uint32_t record_buf[2] = { 0, 0 };
insn_bits24_27 = bits (aarch64_insn_r->aarch64_insn, 24, 27);
insn_bits28_31 = bits (aarch64_insn_r->aarch64_insn, 28, 31);