This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] xtensa: fix access to the last pseudo register
- From: Pedro Alves <palves at redhat dot com>
- To: Max Filippov <jcmvbkbc at gmail dot com>, gdb-patches at sourceware dot org
- Cc: Maxim Grigoriev <maxim2405 at gmail dot com>, Woody LaRue <larue at cadence dot com>, Marc Gauthier <marc at cadence dot com>
- Date: Wed, 27 May 2015 11:16:36 +0100
- Subject: Re: [PATCH] xtensa: fix access to the last pseudo register
- Authentication-results: sourceware.org; auth=none
- References: <1431904329-13965-1-git-send-email-jcmvbkbc at gmail dot com>
On 05/18/2015 12:12 AM, Max Filippov wrote:
> Currently access to the last pseudo register is aliased to a1. This is
> done by little snippets in the beginning of xtensa_pseudo_register_read
> and xtensa_pseudo_register_write that used to do such aliasing for FP
> register since bdb4c075a29dd086f0868b394b488b1c94666be6, but then
> FP_ALIAS was expanded into gdbarch_num_regs (current_gdbarch) +
> gdbarch_num_pseudo_regs (current_gdbarch) (one register past the last
> pseudo register) in 304fe2552d6e0821e8fdb7575f8e7ba6607a076d, which
> then was changed to the last pseudo register in
> 94a0e877111421d300d26b858bd3a0a27078d1e8.
IIUC, the original intention was for FP to alias a1, and then through
that series of patches (part of old current_gdbarch elimination)
we ended up aliasing the wrong register. Instead of fixing the
aliasing, you're just removing it altogether. Correct?
OK.
Thanks,
Pedro Alves