This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] [PR symtab/18258] Fix.
- From: Doug Evans <dje at google dot com>
- To: gdb-patches <gdb-patches at sourceware dot org>
- Date: Wed, 27 May 2015 11:54:01 -0700
- Subject: Re: [PATCH] [PR symtab/18258] Fix.
- Authentication-results: sourceware.org; auth=none
- References: <yjt24mofipup dot fsf at ruffy dot mtv dot corp dot google dot com>
On Thu, Apr 16, 2015 at 5:02 PM, Doug Evans <dje@google.com> wrote:
> Hi.
>
> This patch fixes pr 18258.
> https://sourceware.org/bugzilla/show_bug.cgi?id=18258
>
> The problem is described pretty well in the PR.
> Basically, we need to include the opaque-type test while we're
> iterating over compunit_symtab->includes.
>
> Regression tested on amd64-linux.
>
> 2015-04-16 Doug Evans <dje@google.com>
>
> PR symtab/18258
> * block.c (block_find_symbol): New function.
> (block_find_non_opaque_type): Ditto.
> (block_find_non_opaque_type_preferred): Ditto.
> * block.h (block_symbol_matcher_ftype): New typedef.
> (block_find_symbol): Declare.
> (block_find_non_opaque_type): Ditto.
> (block_find_non_opaque_type_preferred): Ditto.
> * dwarf2read.c (dw2_lookup_symbol): Call block_find_symbol.
> * psymtab.c (psym_lookup_symbol): Ditto.
> * symtab.c (basic_lookup_transparent_type_1): New function.
> (basic_lookup_transparent_type): Call it.
>
> testsuite/
> PR symtab/18258
> * gdb.dwarf2/opaque-type-lookup-2.c: New file.
> * gdb.dwarf2/opaque-type-lookup.c: New file.
> * gdb.dwarf2/opaque-type-lookup.exp: New file.
Committed.