This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [OB PATCH] Don't assume File-I/O mode bits match the host's format
- From: Gary Benson <gbenson at redhat dot com>
- To: Andreas Schwab <schwab at suse dot de>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 9 Jun 2015 14:27:51 +0100
- Subject: Re: [OB PATCH] Don't assume File-I/O mode bits match the host's format
- Authentication-results: sourceware.org; auth=none
- References: <1433853129-9470-1-git-send-email-gbenson at redhat dot com> <mvmzj49f3x1 dot fsf at hawking dot suse dot de>
Andreas Schwab wrote:
> Gary Benson <gbenson@redhat.com> writes:
>
> > + if (fileio_mode & ~FILEIO_S_SUPPORTED)
> > + return -1;
>
> > + if (fileio_mode & FILEIO_S_IFCHR)
> > + mode |= S_IFCHR;
>
> FILEIO_S_SUPPORTED doesn't include FILEIO_S_IFCHR, so this is never
> true.
Good spot!
It seems to me FILEIO_S_SUPPORTED should include FILEIO_S_IFCHR, would
anybody object if I made that change?
Thanks,
Gary
--
http://gbenson.net/