This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] gdbserver <library-list> and its #FIXED version="1.0"
- From: Pedro Alves <palves at redhat dot com>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>, gdb-patches at sourceware dot org
- Date: Wed, 10 Jun 2015 17:17:43 +0100
- Subject: Re: [patch] gdbserver <library-list> and its #FIXED version="1.0"
- Authentication-results: sourceware.org; auth=none
- References: <20111103191640 dot GA27298 at host1 dot jankratochvil dot net>
On 11/03/2011 07:16 PM, Jan Kratochvil wrote:
> I believe the same bug has to apply for existing FSF gdbserver but I do not
> have any <library-list/> platform to test it (I did not try to build MinGW).
>
> features/library-list.dtd:
> <!ATTLIST library-list version CDATA #FIXED "1.0">
>
> http://www.xml.com/pub/a/98/10/guide0.html?page=3 says:
>
> #FIXED
> In this case, the attribute is not required, but if it occurs, it must
> have the specified value.
>
> Which would suggest gdbserver is right but solib-target.c is wrong. One could
> also make gdbserver explicit for the version (if those 14 bytes are not of
> a concern).
Yeah, I couldn't find any other place that handled "version"
optionally. Looking around, it looks like we end up passing
an explicit version number for all xml files but this one.
> + /* #FIXED attribute may be omitted, Expat returns NULL in such case. */
> + if (version)
version != NULL
Otherwise looks fine.
Thanks,
Pedro Alves