This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v3] Fix MI dprintf-insert not printing on a resolved pending location.
- From: Pedro Alves <palves at redhat dot com>
- To: Antoine Tremblay <antoine dot tremblay at ericsson dot com>, gdb-patches at sourceware dot org
- Date: Fri, 12 Jun 2015 13:33:20 +0100
- Subject: Re: [PATCH v3] Fix MI dprintf-insert not printing on a resolved pending location.
- Authentication-results: sourceware.org; auth=none
- References: <5534ED92 dot 1010604 at ericsson dot com> <1434112052-6972-1-git-send-email-antoine dot tremblay at ericsson dot com>
On 06/12/2015 01:27 PM, Antoine Tremblay wrote:
> ---
> Diffs in v3 :
> - some syntax formating for int main
> - wording changes to make it more clear that the pending location is now resolved
> - more explicit mi_expect_stop
Thanks. That does make it more obvious what is going on here.
> This patch fixes the "Format string required" error when trying to print
> a dprintf on a now resolved, pending location when set via the MI interface
> even if the format string is entered correctly.
>
> This patch also adds a test case to check that issue called
> mi-dprintf-pending.exp.
>
OK with:
> +extern void pendfunc ();
(void) here too.
Thank you and thanks Keith too.
--
Pedro Alves