This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
RE: [pushed] [BUILDROBOT] makeinfo fails (was: [pushed] [PATCH V4] Add support for bound table in the Intel MPX context.)
- From: "Tedeschi, Walfred" <walfred dot tedeschi at intel dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: Jan-Benedict Glaw <jbglaw at lug-owl dot de>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Fri, 12 Jun 2015 13:09:55 +0000
- Subject: RE: [pushed] [BUILDROBOT] makeinfo fails (was: [pushed] [PATCH V4] Add support for bound table in the Intel MPX context.)
- Authentication-results: sourceware.org; auth=none
- References: <AC542571535E904D8E8ADAE745D60B194442AD4B at IRSMSX104 dot ger dot corp dot intel dot com> <20150612125439 dot GA2609 at adacore dot com>
Joel,
I will improve the error message and will send you a patch.
Will send for review by moday/Tuesday.
I still can send it as post pushed, so people can contribute to it.
Thanks a lot again,
-Fred
-----Original Message-----
From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-owner@sourceware.org] On Behalf Of Joel Brobecker
Sent: Friday, June 12, 2015 2:55 PM
To: Tedeschi, Walfred
Cc: Jan-Benedict Glaw; gdb-patches@sourceware.org
Subject: Re: [pushed] [BUILDROBOT] makeinfo fails (was: [pushed] [PATCH V4] Add support for bound table in the Intel MPX context.)
> Pushed the fix.
> The final changes were slightly different from what I proposed.
> Basically incorporating two of your comments.
> I still think that we could improve the error message to help user
> understand what is wrong.
> In fact I did not want to wait longer to have a fix for the builds.
>
> In case you have comments on that commit please let me know I will fix
> it immediately!
I agree that a more informative error message would be welcome; that is: explain which feature is not supported, and why it is not.
For the emergency fix, it looks good to me, modulo the above.
Procedurally, when someone pushes a patch that's different from the one that was previously sent, it's customary to email the patch to this mailing-list as well, just for archiving and also to give everyone an opportunity to react to it, just in case.
--
Joel
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk
Registergericht: Muenchen HRB 47456
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052